lkml.org 
[lkml]   [2024]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] acpi: EINJ: mark remove callback as non-__exit
Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The remove callback of a device is called whenever it is unbound,
> which may happen during runtime e.g. through sysfs, so this is not
> allowed to be dropped from the binary:
>
> WARNING: modpost: vmlinux: section mismatch in reference: einj_driver+0x8 (section: .data) -> einj_remove (section: .exit.text)
> ERROR: modpost: Section mismatches detected.
>
> Remove that annotation.

Looks good, not sure why the build robots missed this while this was
sitting in -next. Yes, this was a side effect of reusing the former
einj_exit() as the device remove callback.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

Rafael, can you pick this up?

\
 
 \ /
  Last update: 2024-05-27 15:56    [W:0.043 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site