Messages in this thread | | | From | "Edgecombe, Rick P" <> | Subject | Re: [PATCH v19 120/130] KVM: TDX: Add a method to ignore dirty logging | Date | Mon, 18 Mar 2024 17:43:33 +0000 |
| |
On Mon, 2024-03-18 at 10:12 -0700, Isaku Yamahata wrote: > I categorize as follows. Unless otherwise, I'll update this series. > > - dirty log check > As we will drop this ptach, we'll have no call site. > > - KVM_BUG_ON() in main.c > We should drop them because their logic isn't complex. What about "KVM: TDX: Add methods to ignore guest instruction emulation"? Is it cleanly blocked somehow?
> > - KVM_BUG_ON() in tdx.c > - The error check of the return value from SEAMCALL > We should keep it as it's unexpected error from TDX module. When > we hit > this, we should mark the guest bugged and prevent further > operation. It's > hard to deduce the reason. TDX mdoule might be broken. Yes. Makes sense.
> > - Other check > We should drop them.
Offhand, I'm not sure what is in this category.
| |