Messages in this thread | | | From | Xu Yang <> | Subject | RE: [EXT] Re: [PATCH v9 05/11] dt-bindings: usb: ci-hdrc-usb2-imx: add restrictions for reg, interrupts, clock and clock-names properties | Date | Mon, 18 Mar 2024 03:41:29 +0000 |
| |
> > On Fri, Mar 15, 2024 at 03:24:49PM +0800, Xu Yang wrote: > > Add restrictions for reg, interrupts, clock and clock-names properties > > for imx Socs. > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > > > --- > > [...] > > > + # imx7d Soc need one clock > > + - if: > > + properties: > > + compatible: > > + items: > > + - const: fsl,imx7d-usb > > + - const: fsl,imx27-usb > > + then: > > + properties: > > + clocks: > > + maxItems: 1 > > + clock-names: false > > + > > + # other Soc need one clock > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,imx23-usb > > + - fsl,imx28-usb > > + - fsl,imx50-usb > > + - fsl,imx51-usb > > + - fsl,imx53-usb > > + - fsl,imx6q-usb > > + - fsl,imx6sl-usb > > + - fsl,imx6sx-usb > > + - fsl,imx6ul-usb > > + - fsl,imx8mm-usb > > + - fsl,imx8mn-usb > > + - fsl,vf610-usb > > Can't you add 'fsl,imx7d-usb' here and drop the previous if/then? > > With that,
If I do this I need to remove 'fsl,imx7d-usb' again in patch 06/11. (KK said I'd not better do that) Because imx93 is compatible with imx7d in non-wakeup case, but imx93 need one wakeup clock to support wakeup feature. Here 'contains' 'fsl,imx7d-usb' will include both imx7d and imx7d compliant socs.
Thanks, Xu Yang
> > Reviewed-by: Rob Herring <robh@kernel.org> > > > + then: > > + properties: > > + clocks: > > + maxItems: 1 > > + clock-names: false > > + > > unevaluatedProperties: false > > > > examples: > > -- > > 2.34.1 > >
| |