Messages in this thread | ![/](/images/icornerl.gif) | | From | fan <> | Date | Mon, 18 Mar 2024 09:51:36 -0700 | Subject | Re: [PATCH v2 1/1] cxl/mem: Fix for the index of Clear Event Record Handle |
| |
On Mon, Mar 18, 2024 at 10:29:28AM +0800, Yuquan Wang wrote: > The dev_dbg info for Clear Event Records mailbox command would report > the handle of the next record to clear not the current one. > > This was because the index 'i' had incremented before printing the > current handle value. > > Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn> > --- > drivers/cxl/core/mbox.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c > index 9adda4795eb7..b810a6aa3010 100644 > --- a/drivers/cxl/core/mbox.c > +++ b/drivers/cxl/core/mbox.c > @@ -915,7 +915,7 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds, > > payload->handles[i++] = gen->hdr.handle; > dev_dbg(mds->cxlds.dev, "Event log '%d': Clearing %u\n", log, > - le16_to_cpu(payload->handles[i])); > + le16_to_cpu(payload->handles[i-1]));
LGTM except for the space issue mentioned by Jonathan.
After the fix, Reviewed-by: Fan Ni <fan.ni@samsung.com>
Fan > > if (i == max_handles) { > payload->nr_recs = i; > -- > 2.34.1 >
| ![\](/images/icornerr.gif) |