Messages in this thread | | | Date | Mon, 18 Mar 2024 09:15:03 -0700 (PDT) | Subject | Re: [PATCH v1] perf: starfive: fix 64-bit only COMPILE_TEST condition | From | Palmer Dabbelt <> |
| |
On Mon, 18 Mar 2024 08:35:04 PDT (-0700), Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > ARCH_STARFIVE is not restricted to 64-bit platforms, so while Will's > addition of a 64-bit only condition satisfied the build robots doing > COMPILE_TEST builds, Palmer ran into the same problems with writeq() > being undefined during regular rv32 builds. > > Promote the dependency on 64-bit to its own `depends on` so that the > driver can never be included in 32-bit builds. > > Reported-by: Palmer Dabbelt <palmer@rivosinc.com> > Fixes: c2b24812f7bc ("perf: starfive: Add StarLink PMU support") > Fixes: f0dbc6d0de38 ("perf: starfive: Only allow COMPILE_TEST for 64-bit architectures") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > CC: Will Deacon <will@kernel.org> > CC: Mark Rutland <mark.rutland@arm.com> > CC: Ji Sheng Teoh <jisheng.teoh@starfivetech.com> > CC: linux-arm-kernel@lists.infradead.org > CC: linux-kernel@vger.kernel.org > --- > drivers/perf/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig > index 5060e1f1ea10..7526a9e714fa 100644 > --- a/drivers/perf/Kconfig > +++ b/drivers/perf/Kconfig > @@ -87,7 +87,8 @@ config RISCV_PMU_SBI > filtering, counter configuration. > > config STARFIVE_STARLINK_PMU > - depends on ARCH_STARFIVE || (COMPILE_TEST && 64BIT) > + depends on ARCH_STARFIVE || COMPILE_TEST > + depends on 64BIT > bool "StarFive StarLink PMU" > help > Provide support for StarLink Performance Monitor Unit.
Reviewed-by: Palmer Dabbelt <palmer@rivosinc.com> Acked-by: Palmer Dabbelt <palmer@rivosinc.com>
| |