Messages in this thread | | | Date | Mon, 18 Mar 2024 10:19:39 +0100 | Subject | Re: [PATCH 00/14] mips: dts: ralink: mt7621: improve DTS style | From | Krzysztof Kozlowski <> |
| |
On 18/03/2024 09:48, Sergio Paracuellos wrote: >> >> >>>> But if there're no objections and it lessens the burden on >>>> maintainers upstream to have less patches to apply, then I have no >>>> problem combining them into a single patch. >>>> >>> >>> Yeah, one review response instead of 14 responses... One commit in the >>> history instead of 14. >> >> I agree that 1 commit vs 14 is better. >> >> But for future reference: is it not enough for the Reviewed-by: trailer >> to be sent in response to the cover letter of a patch set if a reviewer >> has looked at the entire set? > > It is enough, AFAICT. I found your patchset very easy to review so I > am ok with the patchset as it is. However, at the end this will be > through the mips tree, so let's do what Thomas prefers: add all > patches as they are or squash all of them in one commit.
Yeah, like fixing language typos in comments: one typo per patch.
Best regards, Krzysztof
| |