Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Arınç ÜNAL via B4 Relay <> | Date | Mon, 18 Mar 2024 10:46:25 +0300 | Subject | [PATCH 3/3] net: phy: mediatek-ge: do not disable EEE advertisement |
| |
From: Arınç ÜNAL <arinc.unal@arinc9.com>
There's no need to disable Energy-Efficient Ethernet (EEE) advertisement on the MT7530 and MT7531 switch PHYs. EEE works fine on MT7530 and MT7531 switch PHYs. Remove the code where EEE advertisement is disabled.
This is a bugfix because there's a possible race condition where the mediatek-ge driver would kick in after the MT7530 DSA subdriver which would have EEE disabled until manually enabled.
Fixes: e40d2cca0189 ("net: phy: add MediaTek Gigabit Ethernet PHY driver") Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> --- drivers/net/phy/mediatek-ge.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/net/phy/mediatek-ge.c b/drivers/net/phy/mediatek-ge.c index a493ae01b267..54ea64a37ab3 100644 --- a/drivers/net/phy/mediatek-ge.c +++ b/drivers/net/phy/mediatek-ge.c @@ -23,9 +23,6 @@ static int mtk_gephy_write_page(struct phy_device *phydev, int page) static void mtk_gephy_config_init(struct phy_device *phydev) { - /* Disable EEE */ - phy_write_mmd(phydev, MDIO_MMD_AN, MDIO_AN_EEE_ADV, 0); - /* Enable HW auto downshift */ phy_modify_paged(phydev, MTK_PHY_PAGE_EXTENDED, 0x14, 0, BIT(4)); -- 2.40.1
| ![\](/images/icornerr.gif) |