Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 18 Mar 2024 19:37:42 -0500 | Subject | Re: [PATCH 1/3] dt-bindings: remoteproc: add Versal platform support | From | Tanmay Shah <> |
| |
Hello,
Thanks for reviews, please find my comments below.
On 3/17/24 9:50 AM, Conor Dooley wrote: > On Fri, Mar 15, 2024 at 02:15:31PM -0700, Tanmay Shah wrote: >> AMD-Xilinx Versal platform is successor of ZynqMP platform. Real-time >> Processor Unit R5 cluster IP on Versal is same as of ZynqMP Platform. > >> Only difference is power-domains ID needed by power management firmware. >> Hence, keeping the compatible property same as of zynqmp node. > > No, don't be lazy. Add a compatible with a fallback please.
It's same IP on different platform. I am not sure how adding compatible string adds value. I will refactor this series based on other comments provided.
> This doesn't apply to linux-next either FYI.
Actually cover-letter contains dependent series link that is needed for this patch. That series was acked recently but hasn't made to linux-next yet.
I may be missing something in the process. In such case there is no other way to send patch except for waiting?
Thanks, Tanmay
| ![\](/images/icornerr.gif) |