Messages in this thread | | | Date | Mon, 18 Mar 2024 16:51:43 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v2] soc: qcom: cmd-db: replace deprecated strncpy with strtomem |
| |
On Mon, Mar 18, 2024 at 10:49:23PM +0000, Justin Stitt wrote: > strncpy() is deprecated for use on NUL-terminated destination strings > [1] and as such we should prefer more robust and less ambiguous string > interfaces. > > @query is already marked as __nonstring and doesn't need to be > NUL-terminated. Since @id is a string, we can use the self-describing > string API strtomem(). > > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] > Link: https://github.com/KSPP/linux/issues/90 > Cc: linux-hardening@vger.kernel.org > Signed-off-by: Justin Stitt <justinstitt@google.com>
Nice! A textbook use for strtomem(). :)
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| |