Messages in this thread | | | Date | Mon, 18 Mar 2024 22:14:11 +0100 | From | Robert Richter <> | Subject | Re: [PATCH 1/3] x86/numa: Fix SRAT lookup for CFMWS ranges with numa_fill_memblks() |
| |
On 18.03.24 22:09:00, Robert Richter wrote: > With kconfig option NUMA_KEEP_MEMINFO disabled the SRAT lookup done > with numa_fill_memblks() fails returning NUMA_NO_MEMBLK (-1). An > existing SRAT memory range cannot be found for a CFMWS address range. > This causes the addition of a duplicate numa_memblk with a different > node id and a subsequent page fault and kernel crash during boot. > > Note that the issue was initially introduced with [1]. But since > phys_to_target_node() was originally used that returned the valid node > 0, an additional numa_memblk was not added. Though, the node id was > wrong too. > > Fix this by enabling NUMA_KEEP_MEMINFO for x86 with ACPI and NUMA > enabled. > > [1] fd49f99c1809 ("ACPI: NUMA: Add a node and memblk for each CFMWS not in SRAT") > > Fixes: 8f1004679987 ("ACPI/NUMA: Apply SRAT proximity domain to entire CFMWS window") > Cc: Derick Marks <derick.w.marks@intel.com> > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Alison Schofield <alison.schofield@intel.com> > Signed-off-by: Robert Richter <rrichter@amd.com>
This patch should be dropped in favor of the other 1/3 patch, it is a leftover.
Thanks,
-Robert
| |