Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 14 Mar 2024 22:19:45 +0100 | Subject | Re: [PATCH 1/5] dt-bindings: pinctrl: qcom-pmic-gpio: add PMXR2230 and PM6450 binding | From | Krzysztof Kozlowski <> |
| |
On 14/03/2024 21:04, Anjelique Melendez wrote: > From: David Collins <quic_collinsd@quicinc.com> > > Update the Qualcomm Technologies, Inc. PMIC GPIO binding documentation > to inclde compatible strings for PMXR2230 and PM6450 PMICs.
Typo, include
Two commits and quite different subjects... Please make it somehow consistent. Prefix is qcom,pmic-gpio, not qcom-pmic-gpio. Start either with capital or lower case - just choose one pattern.
A nit, subject: drop second/last, redundant "binding". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| ![\](/images/icornerr.gif) |