lkml.org 
[lkml]   [2024]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 01/15] dmaengine: bcm2835: Fix several spellos
From
On 3/13/24 08:26, Andrea della Porta wrote:
> On 08:00 Wed 13 Mar , Florian Fainelli wrote:
>>
>>
>> On 3/13/2024 7:08 AM, Andrea della Porta wrote:
>>> Fixed Codespell reported warnings about spelling and coding convention
>>> violations, among which there are also a couple potential operator
>>> precedence issue in macroes.

and s/macroes/macros/

>>>
>>> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
>>
>> There are no spelling errors being fixed in this commit, this is purely
>> stylistic and conforming to the Linux coding style guidelines.
>
> - /* detect a size missmatch */
> - if (buf_len && (d->size != buf_len))
> + /* detect a size mismatch */
> + if (buf_len && d->size != buf_len)
>
> Isn't 'missmatch' a spelling error? Maybe I can drop the word 'several', since it's
> indeed only one...

Can we agree this was easy to miss when 99% of the changes are
stylistic? The summary is that the commit subject and the message are
not describing what this patch is about.
--
Florian

[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2024-03-13 18:02    [W:0.044 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site