Messages in this thread | | | Date | Wed, 13 Mar 2024 15:06:04 +0300 | Subject | Re: [PATCH] net: dsa: mt7530: increase reset hold time | From | Arınç ÜNAL <> |
| |
On 13.03.2024 14:52, Justin Swartz wrote: > > On 2024-03-13 10:59, Arınç ÜNAL wrote: >> This ship has sailed anyway. Now the changes the first patch did must be >> reverted too. I will deal with this from now on, you can stop sending >> patches regarding this. > > At least if the first patch isn't reverted, the approach used is > less likely to result in the problem occuring, IMHO.
I disagree that the previous approach is less likely to result in the problem occurring. If you don't like the delay amount we agreed on, feel free to express a higher amount.
I also disagree on introducing a solution that is in addition to another solution, both of which fix the same problem.
> > The delay between deliberately switching the LEDs off, instead of > only waiting on chip reset logic to handle that, and the reset > assertion could be considered a "reset setup" period to complement > the original reset hold period. > > Increasing the hold period to what should be 5000 - 5100 usec, > definitely made the problem go away my testing, but the previous > approach is (if nothing else) more explicit in its intent.
I don't want any unnecessary complications on the code I'm maintaining. I already gave a clear intent on the patch log that introduces a simpler and more efficient approach, it doesn't need to be on the code.
Arınç
| |