Messages in this thread | | | Date | Wed, 13 Mar 2024 11:43:54 +0100 | From | Michal Kubiak <> | Subject | Re: [PATCH] net: txgbe: fix clk_name exceed MAX_DEV_ID limits |
| |
On Wed, Mar 13, 2024 at 04:06:34PM +0800, Duanqiang Wen wrote: > txgbe register clk which name is i2c_designware.pci_dev_id(), > clk_name will be stored in clk_lookup_alloc. If PCIe bus number > is larger than 0x39, clk_name size will be larger than 20 bytes. > It exceeds clk_lookup_alloc MAX_DEV_ID limits. So the driver > shortened clk_name. > > Fixes: b63f20485e43 ("net: txgbe: Register fixed rate clock") > Signed-off-by: Duanqiang Wen <duanqiangwen@net-swift.com> > --- > drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c > index 93295916b1d2..5b5d5e4310d1 100644 > --- a/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c > +++ b/drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c > @@ -571,7 +571,7 @@ static int txgbe_clock_register(struct txgbe *txgbe) > char clk_name[32]; > struct clk *clk; > > - snprintf(clk_name, sizeof(clk_name), "i2c_designware.%d", > + snprintf(clk_name, sizeof(clk_name), "i2c_dw.%d", > pci_dev_id(pdev)); > > clk = clk_register_fixed_rate(NULL, clk_name, NULL, 0, 156250000); > -- > 2.27.0 > >
I believe the patch is targeted to the "net" tree? If so, the fix looks OK to me.
Thanks, Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
| |