Messages in this thread | | | Date | Wed, 13 Mar 2024 11:59:23 +0300 | Subject | Re: [PATCH] net: dsa: mt7530: increase reset hold time | From | Arınç ÜNAL <> |
| |
On 12.03.2024 22:21, Justin Swartz wrote: > Increase the MT7530 reset hold period from 1000-1100 usec > to 5000-5100 usec. > > This should reduce the likelihood of an incorrect external > crystal frequency selection which may occur when reset is > deasserted too early under certain link conditions. > > Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za> > --- > drivers/net/dsa/mt7530.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c > index 3c1f65759..5e9e1381a 100644 > --- a/drivers/net/dsa/mt7530.c > +++ b/drivers/net/dsa/mt7530.c > @@ -2243,11 +2243,11 @@ mt7530_setup(struct dsa_switch *ds) > */ > if (priv->mcm) { > reset_control_assert(priv->rstc); > - usleep_range(1000, 1100); > + usleep_range(5000, 5100); > reset_control_deassert(priv->rstc); > } else { > gpiod_set_value_cansleep(priv->reset, 0); > - usleep_range(1000, 1100); > + usleep_range(5000, 5100); > gpiod_set_value_cansleep(priv->reset, 1); > } >
Again, the patch subject is missing the indication of a tree. Read the networking subsystem (netdev) development page [1].
This ship has sailed anyway. Now the changes the first patch did must be reverted too. I will deal with this from now on, you can stop sending patches regarding this.
[1] https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Arınç
| |