Messages in this thread | | | From | OGAWA Hirofumi <> | Subject | Re: [PATCH] fat: ignore .. subdir and always add a link to dirs | Date | Wed, 13 Mar 2024 17:05:41 +0900 |
| |
Thadeu Lima de Souza Cascardo <cascardo@igalia.com> writes:
>> You are forgetting to count about normal dirs other than "." and ".."? >> > > Yes, I was not counting those. The patch simply ignores ".." when counting dirs > (which is used only for determining the number of links), and always adds one > link. Then, when validating the inode, it also only requires that at least one > link exists instead of two.
So you break the mkdir/rmdir link counting, isn't it?
Thanks.
> There is only one other instance of fat_subdirs being called and that's when > the root dir link count is determined. I left that one unchanged, as usually > "." and ".." does not exist there and we always add two links there. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
| |