Messages in this thread | | | Date | Wed, 13 Mar 2024 19:32:20 -0700 | From | Alison Schofield <> | Subject | Re: [PATCH] staging: greybus: add comment for mutex |
| |
On Wed, Mar 13, 2024 at 11:51:22PM +0530, Ayush Tiwari wrote: > This patch adds descriptive comment to mutex within the struct > gbaudio_codec_info to clarify its intended use and to address > checkpatch checks.
Hi Ayush-
You may be right, but you need to convince your patch reviewers why your comment accurately describes this mutex.
That's always the ask with this kind of patch.
BTW - Don't start your commit log with 'This patch...'.
Alison
> > Signed-off-by: Ayush Tiwari <ayushtiw0110@gmail.com> > --- > drivers/staging/greybus/audio_codec.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h > index f3f7a7ec6be4..1f97d4fb16cd 100644 > --- a/drivers/staging/greybus/audio_codec.h > +++ b/drivers/staging/greybus/audio_codec.h > @@ -71,6 +71,7 @@ struct gbaudio_codec_info { > /* to maintain runtime stream params for each DAI */ > struct list_head dai_list; > struct mutex lock; > + /* Lock to protect register access */ > struct mutex register_mutex; > }; > > -- > 2.40.1 > >
| |