lkml.org 
[lkml]   [2024]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] fs: sysfs: Fix reference leak in sysfs_break_active_protection()
From
On 3/13/24 14:43, Alan Stern wrote:
> The sysfs_break_active_protection() routine has an obvious reference
> leak in its error path. If the call to kernfs_find_and_get() fails then
> kn will be NULL, so the companion sysfs_unbreak_active_protection()
> routine won't get called (and would only cause an access violation by
> trying to dereference kn->parent if it was called). As a result, the
> reference to kobj acquired at the start of the function will never be
> released.
>
> Fix the leak by adding an explicit kobject_put() call when kn is NULL.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

\
 
 \ /
  Last update: 2024-03-13 23:10    [W:0.030 / U:1.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site