lkml.org 
[lkml]   [2024]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration sequences
Date

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Wednesday, March 13, 2024 3:53 PM
> To: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ronnie Kunin - C21729 <Ronnie.Kunin@microchip.com>; Raju Lakkaraju - I30499
> <Raju.Lakkaraju@microchip.com>; netdev@vger.kernel.org; davem@davemloft.net; kuba@kernel.org;
> linux-kernel@vger.kernel.org; Bryan Whitehead - C21958 <Bryan.Whitehead@microchip.com>;
> richardcochran@gmail.com; UNGLinuxDriver <UNGLinuxDriver@microchip.com>
> Subject: Re: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration
> sequences
>
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> So i think we need to agree on best practices for new drivers and document what that is, probably in
> both the ethtool man page and include/uapi/linux/ethtool.h
>
> * WAKE_MAGIC on its own is O.K.
> * WAKE_MAGICSECURE without WAKE_MAGIC is invalid. -EINVAL
> * WAKE_MAGIC + WAKE_MAGICSECURE means only secure magic WoL.
> * Each driver needs to enforce this, due to backwards compatibility.
> Some may decide not to.
>
> Can we agree on this?

Sounds good to me.
Raju (and other MCHP folks) are out this week due to a company shutdown, but he should be able to submit a new patch for lan743x as described above when back next week.

>
> Andrew


\
 
 \ /
  Last update: 2024-03-13 21:34    [W:0.090 / U:1.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site