Messages in this thread | | | Date | Wed, 13 Mar 2024 20:52:42 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net 3/3] net: lan743x: Address problems with wake option flags configuration sequences |
| |
So i think we need to agree on best practices for new drivers and document what that is, probably in both the ethtool man page and include/uapi/linux/ethtool.h
* WAKE_MAGIC on its own is O.K. * WAKE_MAGICSECURE without WAKE_MAGIC is invalid. -EINVAL * WAKE_MAGIC + WAKE_MAGICSECURE means only secure magic WoL. * Each driver needs to enforce this, due to backwards compatibility. Some may decide not to.
Can we agree on this?
Andrew
| |