Messages in this thread | | | From | Trevor Gross <> | Date | Wed, 13 Mar 2024 15:09:57 -0400 | Subject | Re: [PATCH] rust: add `Module::as_ptr` |
| |
On Mon, Feb 26, 2024 at 5:13 AM Alice Ryhl <aliceryhl@google.com> wrote: > > This allows you to get a raw pointer to THIS_MODULE for use in unsafe > code. The Rust Binder RFC uses it when defining fops for the binderfs > component [1]. > > This doesn't really need to go in now - it could go in together with > Rust Binder like how it is sent in the Rust Binder RFC. However, the > upcoming 1.77.0 release of the Rust compiler introduces a new warning, > and applying this patch now will silence that warning. That allows us to > avoid adding the #[allow(dead_code)] annotation seen in [2]. > > Link: https://lore.kernel.org/rust-for-linux/20231101-rust-binder-v1-2-08ba9197f637@google.com/ [1] > Link: https://lore.kernel.org/all/20240217002717.57507-1-ojeda@kernel.org/ [2] > Signed-off-by: Alice Ryhl <aliceryhl@google.com> > ---
Reviewed-by: Trevor Gross <tmgross@umich.edu>
This exposes a `bindings` type to the user which we don't really do in many other places, but it makes sense here of course.
| |