lkml.org 
[lkml]   [2024]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/3] arm64: dts: qcom: Add initial support for rb5gen2 SOM
From


On 3/13/24 08:12, Wasim Nazir wrote:
> Rb5gen2 SOM is based on QCS8550 SoC, used for Rb5gen2 board.
> This initial version describes regulators & ufs storage.

[...]

> +
> +&ufs_mem_hc {
> + reset-gpios = <&tlmm 210 GPIO_ACTIVE_LOW>;
> + vcc-supply = <&vreg_l17b_2p5>;
> + vcc-max-microamp = <1300000>;
> + vccq-supply = <&vreg_l1g_1p2>;
> + vccq-max-microamp = <1200000>;

You want regulator-allow-set-mode and regulator-allowed-modes,
unless for some reason you want them to be in HPM permanently,
in which case you should definitely comment why

Konrad

\
 
 \ /
  Last update: 2024-03-13 20:11    [W:0.106 / U:0.924 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site