Messages in this thread | | | Date | Wed, 13 Mar 2024 09:01:24 +0300 | From | Dan Carpenter <> | Subject | Re: [v1] staging: media: starfive: Clean pad selection in isp_try_format() |
| |
On Mon, Mar 11, 2024 at 07:45:20PM -0700, Changhuang Liang wrote: > The code to select isp_dev->formats[] is overly complicated. We can > just use the "pad" as the index. This will making adding new pads > easier in future patches. No functional change. > > Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> > ---
I'm not sure that patchwork will find this patch if it doesn't have [PATCH] in the subject... But otherwise the patch looks good. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards, dan carpenter
| |