lkml.org 
[lkml]   [2024]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v7 1/2] spi: Unify error codes by replacing -ENOTSUPP with -EOPNOTSUPP
From
On 3/13/24 08:56, Michael Walle wrote:
> Hi,
>
> I just had a quick look to see where Florians breakage could come
> from and just noticed this:
>
>> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
>> index 849ccfedbc72..e0b6715e5dfe 100644
>> --- a/drivers/mtd/nand/spi/core.c
>> +++ b/drivers/mtd/nand/spi/core.c
>> @@ -974,7 +974,7 @@ static int spinand_manufacturer_match(struct spinand_device *spinand,
>> spinand->manufacturer = manufacturer;
>> return 0;
>> }
>> - return -ENOTSUPP;
>> + return -EOPNOTSUPP;
>> }
>>
>> static int spinand_id_detect(struct spinand_device *spinand)
>
> This seems to be random as no other spi-nand ENOTSUPP was converted
> but just this. Is there a reason for this, AceLan?

FWIW, we do not have any SPI-NAND flashes on those boards only SPI-NOR,
just posted a fix for this:

https://lore.kernel.org/r/20240313171050.3505620-1-florian.fainelli@broadcom.com
--
Florian

[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2024-03-13 19:33    [W:0.112 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site