Messages in this thread | | | Date | Wed, 13 Mar 2024 18:11:50 +0100 | Subject | Re: [PATCH 12/18] ASoC: codecs: mt6357: add MT6357 codec | From | Alexandre Mergnat <> |
| |
On 26/02/2024 17:09, Mark Brown wrote: >> index 000000000000..13e95c227114 >> --- /dev/null >> +++ b/sound/soc/codecs/mt6357.c >> @@ -0,0 +1,1805 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * MT6357 ALSA SoC audio codec driver >> + * > Please use a C++ comment for the whole comment to make it clearer that > this is intentional.
If I do that, the checkpatch raise a warning:
WARNING: Improper SPDX comment style for 'sound/soc/mediatek/mt8365/mt8365-afe-clk.c', please use '//' instead #22: FILE: sound/soc/mediatek/mt8365/mt8365-afe-clk.c:1: +/* SPDX-License-Identifier: GPL-2.0
WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 #22: FILE: sound/soc/mediatek/mt8365/mt8365-afe-clk.c:1: +/* SPDX-License-Identifier: GPL-2.0
even if I put: /* SPDX-License-Identifier: GPL-2.0 */
IMO, the checkpatch tool should be fixed/update first.
-- Regards, Alexandre
| |