Messages in this thread | ![/](/images/icornerl.gif) | | From | Michael Chan <> | Date | Mon, 11 Mar 2024 10:22:30 -0700 | Subject | Re: [PATCH v2] tg3: Remove residual error handling in tg3_suspend |
| |
On Mon, Mar 11, 2024 at 8:45 AM Nikita Kiryushin <kiryushin@ancud.ru> wrote: > > > As of now, tg3_power_down_prepare always ends with success, but > the error handling code from former tg3_set_power_state call is still here. > > Remove (now unreachable) code for simplification and change > tg3_power_down_prepare to a void function as its result is no more checked. > > Found by Linux Verification Center (linuxtesting.org) with SVACE. > > Fixes: c866b7eac073 ("tg3: Do not use legacy PCI power management") > Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru> > --- > v2: Change tg3_power_down_prepare() to a void function > as Michael Chan <michael.chan@broadcom.com> suggested. > drivers/net/ethernet/broadcom/tg3.c | 30 ++++------------------------- > 1 file changed, 4 insertions(+), 26 deletions(-)
The patch looks good to me. But this cleanup patch should be for net-next and net-next is closed right now. Please re-post in about 2 weeks. You can add my tag when you repost:
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Thanks. [unhandled content-type:application/pkcs7-signature] | ![\](/images/icornerr.gif) |