lkml.org 
[lkml]   [2024]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 2/2] net: amt: Remove generic .ndo_get_stats64
From


On 3/9/24 1:26 AM, Breno Leitao wrote:
> Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
> configured") moved the callback to dev_get_tstats64() to net core, so,
> unless the driver is doing some custom stats collection, it does not
> need to set .ndo_get_stats64.
>
> Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
> doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
> function pointer.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
> drivers/net/amt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/amt.c b/drivers/net/amt.c
> index cb31d1990660..6d15ab3bfbbc 100644
> --- a/drivers/net/amt.c
> +++ b/drivers/net/amt.c
> @@ -3084,7 +3084,6 @@ static const struct net_device_ops amt_netdev_ops = {
> .ndo_open = amt_dev_open,
> .ndo_stop = amt_dev_stop,
> .ndo_start_xmit = amt_dev_xmit,
> - .ndo_get_stats64 = dev_get_tstats64,
> };
>
> static void amt_link_setup(struct net_device *dev)

Hi Breno, Thanks a lot for this series!

Reviewed-by: Taehee Yoo <ap420073@gmail.com>

\
 
 \ /
  Last update: 2024-05-27 15:43    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog