Messages in this thread | | | Date | Mon, 11 Mar 2024 14:51:43 +0100 | From | Maxime Chevallier <> | Subject | Re: [PATCH v2] net: macb: remove change_mtu callback |
| |
Hello Thomas,
On Mon, 11 Mar 2024 10:12:11 +0100 thomas.perrot@bootlin.com wrote:
> Subject: [PATCH v2] net: macb: remove change_mtu callback
You need to specify in the subject whether this patch targets net (for bug fixes, in which case you need a Fixes: tag) or net-next for new features/improvements.
You can use this parameter in your git format-patch command to have it set properly :
--subject-prefix="PATCH net-next" (or net)
Thanks,
Maxime
> From: Thomas Perrot <thomas.perrot@bootlin.com> > > Because it doesn't allow MTU changes when the interface is up, although > it is not necessary. > > This callback has been added to add in a first implementation of the Jumbo > support [1],since it has been reworked and moved to the probe [2]. > > With this patch the core will set the MTU, regardless of if the interface > is up or not. > > [1] commit a5898ea09aad ("net: macb: Add change_mtu callback with > jumbo support") > [2] commit 44770e1180de ("ethernet: use core min/max MTU checking") > > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com> > --- > > Changes since v2: > - Update the commit message. > > drivers/net/ethernet/cadence/macb_main.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c > index 898debfd4db3..0532215e5236 100644 > --- a/drivers/net/ethernet/cadence/macb_main.c > +++ b/drivers/net/ethernet/cadence/macb_main.c > @@ -3017,16 +3017,6 @@ static int macb_close(struct net_device *dev) > return 0; > } > > -static int macb_change_mtu(struct net_device *dev, int new_mtu) > -{ > - if (netif_running(dev)) > - return -EBUSY; > - > - dev->mtu = new_mtu; > - > - return 0; > -} > - > static int macb_set_mac_addr(struct net_device *dev, void *addr) > { > int err; > @@ -3897,7 +3887,6 @@ static const struct net_device_ops macb_netdev_ops = { > .ndo_get_stats = macb_get_stats, > .ndo_eth_ioctl = macb_ioctl, > .ndo_validate_addr = eth_validate_addr, > - .ndo_change_mtu = macb_change_mtu, > .ndo_set_mac_address = macb_set_mac_addr, > #ifdef CONFIG_NET_POLL_CONTROLLER > .ndo_poll_controller = macb_poll_controller, > -- > 2.44.0 >
| |