Messages in this thread | ![/](/images/icornerl.gif) | | From | Subbaraya Sundeep Bhatta <> | Subject | RE: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic .ndo_get_stats64 | Date | Mon, 11 Mar 2024 11:36:14 +0000 |
| |
>-----Original Message----- >From: Breno Leitao <leitao@debian.org> >Sent: Monday, March 11, 2024 4:55 PM >To: David S. Miller <davem@davemloft.net>; Eric Dumazet ><edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni ><pabeni@redhat.com> >Cc: keescook@chromium.org; Ido Schimmel <idosch@nvidia.com>; Nikolay >Aleksandrov <razor@blackwall.org>; Amit Cohen <amcohen@nvidia.com>; Petr >Machata <petrm@nvidia.com>; Jiri Benc <jbenc@redhat.com>; Beniamino >Galvani <b.galvani@gmail.com>; Gavin Li <gavinl@nvidia.com>; open >list:NETWORKING DRIVERS <netdev@vger.kernel.org>; open list <linux- >kernel@vger.kernel.org> >Subject: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic >.ndo_get_stats64 > >Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is >configured") moved the callback to dev_get_tstats64() to net core, so, >unless the driver is doing some custom stats collection, it does not >need to set .ndo_get_stats64. > >Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it >doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 >function pointer. > >Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com> ..
| ![\](/images/icornerr.gif) |