Messages in this thread | | | Date | Mon, 11 Mar 2024 18:03:34 +0800 | Subject | Re: [PATCH v4] arm64: dts: qcom: qcm6490-idp: enable PMIC Volume and Power buttons | From | hui liu <> |
| |
On 3/6/2024 3:56 PM, Dmitry Baryshkov wrote: > On Wed, 6 Mar 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote: >> >> >> >> On 3/6/2024 5:20 AM, Konrad Dybcio wrote: >>> >>> >>> On 3/4/24 08:09, Hui Liu via B4 Relay wrote: >>>> From: Hui Liu <quic_huliu@quicinc.com> >>>> >>>> The Volume Down & Power buttons are controlled by the PMIC via >>>> the PON hardware, and the Volume Up is connected to a PMIC gpio. >>>> >>>> Enable the necessary hardware and setup the GPIO state for the >>>> Volume Up gpio key. >>>> >>>> Signed-off-by: Hui Liu <quic_huliu@quicinc.com> >>>> --- >>> >>> [...] >>> >>> >>>> +&pmk8350_pon { >>>> + status = "okay"; >>>> +}; >>> >>> This device is already enabled >> Hi Konrad, >> >> The status is not set in pmk8350.dtsi, so I thought we should set it for >> "okay" manually. Do you think so? > > What is the default device status if there is no status property? The default status is okay. OK, I will update it, remove the status configuration.
Thanks, Hui > >
| |