Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 11 Mar 2024 17:55:36 +0800 | Subject | Re: [PATCH V5 net-next 4/4] net: hns3: add support to query scc version by devlink info | From | Jijie Shao <> |
| |
on 2024/3/11 17:19, Simon Horman wrote: >> +#define HNAE3_SCC_VERSION_BYTE1_SHIFT 8 >> +#define HNAE3_SCC_VERSION_BYTE1_MASK GENMASK(15, 8) >> +#define HNAE3_SCC_VERSION_BYTE0_SHIFT 0 >> +#define HNAE3_SCC_VERSION_BYTE0_MASK GENMASK(7, 0) > Not strictly related to this patch, but FWIIW, I suspect that > hnae3_set_field() and hnae3_get_field() could be reworked to use / replaced > by use of FIELD_PREP and FIELD_GET. In which case I suspect that the > *_SHIFT #defines would no longer be needed.
Yes, using FIELD_PREP and FIELD_GET is a better option. But I'm not going to modify this patch. If it's necessary, I will send a cleanup patch later to replace all hnae3_set_field/hnae3_get_field in driver.
| ![\](/images/icornerr.gif) |