lkml.org 
[lkml]   [2024]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v6 3/4] kvm: arm64: set io memory s2 pte as normalnc for vfio pci device
Date
>> +		/*
>> + * To provide VM with the ability to get device IO memory
>> + * with NormalNC property, map device MMIO as NormalNC in S2.
>> + */
>
> nit: the comment doesn't provide anything of value, the logic is rather
> straightforward here.

Sure, will remove it.

>>
>> +     vfio_allow_wc = (vma->vm_flags & VM_VFIO_ALLOW_WC);
>
> Nitpick: no need for brackets, '=' has a pretty low precedence.
>
> Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>

Will change it. Thanks for the review.
\
 
 \ /
  Last update: 2024-05-27 14:56    [W:0.225 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site