Messages in this thread | ![/](/images/icornerl.gif) | | From | Ankit Agrawal <> | Subject | Re: [PATCH v6 3/4] kvm: arm64: set io memory s2 pte as normalnc for vfio pci device | Date | Fri, 9 Feb 2024 14:05:32 +0000 |
| |
>> + /* >> + * To provide VM with the ability to get device IO memory >> + * with NormalNC property, map device MMIO as NormalNC in S2. >> + */ > > nit: the comment doesn't provide anything of value, the logic is rather > straightforward here.
Sure, will remove it.
>> >> + vfio_allow_wc = (vma->vm_flags & VM_VFIO_ALLOW_WC); > > Nitpick: no need for brackets, '=' has a pretty low precedence. > > Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Will change it. Thanks for the review.
| ![\](/images/icornerr.gif) |