Messages in this thread | | | Date | Wed, 7 Feb 2024 09:38:36 -0700 | From | Jerry Snitselaar <> | Subject | Re: [PATCH v3 1/3] iommu/iova: Tidy up iova_cache_get() failure |
| |
On Mon, Feb 05, 2024 at 03:32:39PM +0000, Robin Murphy wrote: > Failure handling in iova_cache_get() is a little messy, and we'd like > to add some more to it, so let's tidy up a bit first. By leaving the > hotplug handler until last we can take advantage of kmem_cache_destroy() > being NULL-safe to have a single cleanup label. We can also improve the > error reporting, noting that kmem_cache_create() already screams if it > fails, so that one is redundant. > > Signed-off-by: Robin Murphy <robin.murphy@arm.com> > --- > drivers/iommu/iova.c | 33 ++++++++++++++++----------------- > 1 file changed, 16 insertions(+), 17 deletions(-) >
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
| |