Messages in this thread | | | Date | Wed, 7 Feb 2024 16:15:21 +0100 | Subject | Re: [PATCH] dt-bindings: input: atmel,captouch: convert bindings to YAML | From | Krzysztof Kozlowski <> |
| |
On 07/02/2024 10:08, Dharma Balasubiramani wrote: > Convert the Atmel capacitive touchscreen bindings to YAML format. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.co
Thank you for your patch. There is something to discuss/improve.
> + > +properties: > + compatible: > + const: atmel,captouch > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + linux,keycodes: > + minItems: 1 > + maxItems: 8 > + > + autorepeat: > + type: boolean
You can drop entire property, coming from input.yaml.
> + > +required: > + - compatible > + - reg > + - interrupts > + - linux,keycodes > + > +additionalProperties: false
Instead: unevaluatedProperties: false
> + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/input/linux-event-codes.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + atmel-captouch@51 {
Instead: touchscreen? touchpad? if none of these, then just "touch@51"
> + compatible = "atmel,captouch"; > + reg = <0x51>;
Best regards, Krzysztof
| |