Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Wed, 7 Feb 2024 15:23:07 +0100 | Subject | Re: [PATCH v5 2/9] watchdog: rzg2l_wdt: Make the driver depend on PM |
| |
Hi Claudiu,
On Wed, Feb 7, 2024 at 2:08 PM Claudiu <claudiu.beznea@tuxon.dev> wrote: > From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > The rzg2l_wdt watchdog driver cannot work w/o CONFIG_PM=y (e.g. the > clocks are enabled though pm_runtime_* specific APIs). To avoid building > a driver that doesn't work make explicit the dependency on CONFIG_PM. Along > with it the dependency on CONFIG_PM and CONFIG_COMPILE_TEST was moved to a > new line to have the code simpler. > > Suggested-by: Guenter Roeck <linux@roeck-us.net> > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > --- > > Changes in v5: > - updated patch description > - added on a new line the dependency on PM and COMPILE_TEST
Thanks for the update!
> --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -910,7 +910,8 @@ config RENESAS_RZN1WDT > > config RENESAS_RZG2LWDT > tristate "Renesas RZ/G2L WDT Watchdog" > - depends on ARCH_RZG2L || ARCH_R9A09G011 || COMPILE_TEST > + depends on ARCH_RZG2L || ARCH_R9A09G011
Please drop this change (i.e. retain the "|| COMPILE_TEST"), as it prevents compile-testing on any platforms but RZ/G2L(alike) and RZ/V2M.
> + depends on PM || COMPILE_TEST > select WATCHDOG_CORE > help > This driver adds watchdog support for the integrated watchdogs in the
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |