Messages in this thread | | | Date | Wed, 7 Feb 2024 15:14:58 +0100 | From | Alexander Gordeev <> | Subject | Re: [PATCH 4/5] s390/irq,nmi: do not include <linux/vtime.h> header |
| |
On Mon, Jan 29, 2024 at 10:51:44AM +0100, Heiko Carstens wrote: > It is confusing when the patch subject is "do not include.." and all > what this patch is doing is to add two includes. I see what this is > doing: getting rid of the implicit include of asm/vtime.h most likely > via linux/hardirq.h, but that's not very obvious. > > Anyway: > Acked-by: Heiko Carstens <hca@linux.ibm.com>
Thank you, Heiko!
Whether this wording sounds better?
s390/irq,nmi: include <asm/vtime.h> header directly
update_timer_sys() and update_timer_mcck() are inlines used for CPU time accounting from the interrupt and machine-check handlers. These routines are specific to s390 architecture, but included via <linux/vtime.h> header implicitly. Avoid the extra loop and include <asm/vtime.h> header directly.
| |