Messages in this thread | | | From | Kamlesh Gurudasani <> | Subject | Re: [PATCH v3] clk: keystone: sci-clk: Adding support for non contiguous clocks | Date | Wed, 7 Feb 2024 19:15:38 +0530 |
| |
Nishanth Menon <nm@ti.com> writes:
> > A bit too nice coding ;) => I had been confused momentarily by clk_id = args.args[1] > change just above till I saw that you are pre-incrementing > clk_id - Is there a harm in leaving the original clk_id increment logic > alone (it was much simpler to read up)? > Personlly, I think this is simpler as this keeps everything related to parents inside while loop and increment only at one place.
The other logic will have increment inside condition and also at 2 other places.
Let's Udit take a call.
Kamlesh
| |