Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 7 Feb 2024 13:48:35 +0200 | From | Raag Jadav <> | Subject | Re: [PATCH v1 1/3] pwm: dwc: Add 16 channel support for Intel Elkhart Lake |
| |
On Fri, Feb 02, 2024 at 06:02:46AM +0200, Raag Jadav wrote: > On Thu, Feb 01, 2024 at 01:26:53PM +0200, Andy Shevchenko wrote: > > On Tue, Jan 30, 2024 at 12:30:23PM +0200, Raag Jadav wrote: > > > On Sun, Jan 28, 2024 at 04:53:24PM +0200, Andy Shevchenko wrote: > > > > On Mon, Jan 22, 2024 at 08:32:36AM +0530, Raag Jadav wrote: > > > > > Intel Elkhart Lake PSE includes two instances of PWM as a single PCI > > > > > function with 8 channels each. Add support for the remaining channels. > > > > ... > > > > > > First option: Always provide driver data (info is never NULL). > > > > > > Allowing empty driver_data would save us from adding dummy info > > > for single instance devices in the future. > > > > Which may be too premature "optimisation". Why? Because if we ever have > > something like pci_dev_get_match_data(), the empty will mean NULL, and > > we may not get difference between empty and missing one. > > Not sure if I'm able to find such a helper as of now, but fair. > I can change it in v2 if Jarkko is okay with it.
Hi Jarkko,
If you agree with Andy's comments, please let me know. Will send out a v2 accordingly.
Raag
| ![\](/images/icornerr.gif) |