lkml.org 
[lkml]   [2024]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [syzbot] [usb?] [media?] possible deadlock in vb2_video_unregister_device
Date
On Wed, 07 Feb 2024 00:44:22 -0800
> HEAD commit: ed5551279c91 Merge 6.8-rc3 into usb-next
> git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1603629fe80000

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing

--- x/drivers/media/usb/usbtv/usbtv-video.c
+++ y/drivers/media/usb/usbtv/usbtv-video.c
@@ -963,11 +963,11 @@ ctrl_fail:

void usbtv_video_free(struct usbtv *usbtv)
{
+ usbtv_stop(usbtv);
+ vb2_video_unregister_device(&usbtv->vdev);
mutex_lock(&usbtv->vb2q_lock);
mutex_lock(&usbtv->v4l2_lock);

- usbtv_stop(usbtv);
- vb2_video_unregister_device(&usbtv->vdev);
v4l2_device_disconnect(&usbtv->v4l2_dev);

mutex_unlock(&usbtv->v4l2_lock);
--
\
 
 \ /
  Last update: 2024-05-27 14:52    [W:0.144 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site