Messages in this thread | | | From | Oleksandr Natalenko <> | Subject | Re: [PATCH v3 6/7] cpufreq: amd-pstate: remove legacy set_boost callback for passive mode | Date | Wed, 07 Feb 2024 11:10:52 +0100 |
| |
Hello.
On středa 7. února 2024 10:21:57 CET Perry Yuan wrote: > With new freqency boost interface supported, legacy boost control > doesn't make sense any more which only support passive mode. > so it can remove the legacy set_boost interface from amd-pstate driver > in case of there is conflict with new boost control logic. > > Signed-off-by: Perry Yuan <perry.yuan@amd.com> > --- > drivers/cpufreq/amd-pstate.c | 1 - > include/linux/amd-pstate.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > index 35791efc6e88..1dd523db3871 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -1675,7 +1675,6 @@ static struct cpufreq_driver amd_pstate_driver = { > .exit = amd_pstate_cpu_exit, > .suspend = amd_pstate_cpu_suspend, > .resume = amd_pstate_cpu_resume, > - .set_boost = amd_pstate_set_boost, > .update_limits = amd_pstate_update_limits, > .name = "amd-pstate", > .attr = amd_pstate_attr, > diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h > index 465e9295a60c..ab7ca26974da 100644 > --- a/include/linux/amd-pstate.h > +++ b/include/linux/amd-pstate.h > @@ -93,7 +93,6 @@ struct amd_cpudata { > struct amd_aperf_mperf prev; > > u64 freq; > - bool boost_supported;
As a result of this removal the kernel-doc for this struct should be amended too because even after this patch is applied the `boost_supported` field remains documented.
> bool hw_prefcore; > > /* EPP feature related attributes*/ >
-- Oleksandr Natalenko (post-factum)[unhandled content-type:application/pgp-signature] | |