Messages in this thread | | | Date | Wed, 7 Feb 2024 10:15:34 +0100 | Subject | Re: [PATCH] drivers/ps3: select VIDEO to provide cmdline functions | From | Thomas Zimmermann <> |
| |
Hi
Am 07.02.24 um 04:37 schrieb Randy Dunlap: > When VIDEO is not set, there is a build error. Fix that by selecting > VIDEO for PS3_PS3AV. > > ERROR: modpost: ".video_get_options" [drivers/ps3/ps3av_mod.ko] undefined! > > Fixes: dae7fbf43fd0 ("driver/ps3: Include <video/cmdline.h> for mode parsing")
Thanks for the fix. Please also add
Fixes: a3b6792e990d ("video/cmdline: Introduce CONFIG_VIDEO for video= parameter") Cc: linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org
That's the commit that exposed the problem. IDK why the old config option VIDEO_CMDLINE worked.
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Nicholas Piggin <npiggin@gmail.com> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu> > Cc: Aneesh Kumar K.V <aneesh.kumar@kernel.org> > Cc: Naveen N. Rao <naveen.n.rao@linux.ibm.com> > Cc: linuxppc-dev@lists.ozlabs.org > Cc: Thomas Zimmermann <tzimmermann@suse.de> > Cc: Geoff Levand <geoff@infradead.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> --- > arch/powerpc/platforms/ps3/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff -- a/arch/powerpc/platforms/ps3/Kconfig b/arch/powerpc/platforms/ps3/Kconfig > --- a/arch/powerpc/platforms/ps3/Kconfig > +++ b/arch/powerpc/platforms/ps3/Kconfig > @@ -67,6 +67,7 @@ config PS3_VUART > config PS3_PS3AV > depends on PPC_PS3 > tristate "PS3 AV settings driver" if PS3_ADVANCED > + select VIDEO > select PS3_VUART > default y > help
-- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
| |