Messages in this thread | | | Date | Wed, 7 Feb 2024 10:11:38 +0200 | Subject | Re: [PATCH v2 3/4] arch/x86/events/core: use scnprintf to print sub-string | From | Adrian Hunter <> |
| |
On 26/01/24 08:13, Li Zhijian wrote: > sysfs_emit is not suitable to to print a substring, convert it to scnprintf
'to to' -> 'to'
> to make coccicheck happy. > > CC: Peter Zijlstra <peterz@infradead.org> > CC: Ingo Molnar <mingo@redhat.com> > CC: Arnaldo Carvalho de Melo <acme@kernel.org> > CC: Mark Rutland <mark.rutland@arm.com> > CC: Alexander Shishkin <alexander.shishkin@linux.intel.com> > CC: Jiri Olsa <jolsa@kernel.org> > CC: Namhyung Kim <namhyung@kernel.org> > CC: Ian Rogers <irogers@google.com> > CC: Adrian Hunter <adrian.hunter@intel.com> > CC: Thomas Gleixner <tglx@linutronix.de> > CC: Borislav Petkov <bp@alien8.de> > CC: Dave Hansen <dave.hansen@linux.intel.com> > CC: x86@kernel.org > CC: "H. Peter Anvin" <hpa@zytor.com> > CC: linux-perf-users@vger.kernel.org > Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> --- > V2: new patch address coccinelle warning > --- > arch/x86/events/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/events/core.c b/arch/x86/events/core.c > index 20d963196e4c..5ed2ba16c6c0 100644 > --- a/arch/x86/events/core.c > +++ b/arch/x86/events/core.c > @@ -1892,7 +1892,7 @@ ssize_t events_hybrid_sysfs_show(struct device *dev, > if (x86_pmu.hybrid_pmu[i].pmu_type & pmu->pmu_type) { > next_str = strchr(str, ';'); > if (next_str) > - return snprintf(page, next_str - str + 1, "%s", str); > + return scnprintf(page, next_str - str + 1, "%s", str); > else > return sysfs_emit(page, "%s", str); > }
| |