lkml.org 
[lkml]   [2024]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] bus: mhi: host: free buffer on error in mhi_alloc_bhie_table
    Date
    img_info->mhi_buf should be freed on error path in mhi_alloc_bhie_table().
    This error case is rare but still needs to be fixed.

    Found by Linux Verification Center (linuxtesting.org).

    Fixes: 3000f85b8f47 ("bus: mhi: core: Add support for basic PM operations")
    Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
    ---
    drivers/bus/mhi/host/boot.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/bus/mhi/host/boot.c b/drivers/bus/mhi/host/boot.c
    index edc0ec5a0933..738dcd11b66f 100644
    --- a/drivers/bus/mhi/host/boot.c
    +++ b/drivers/bus/mhi/host/boot.c
    @@ -357,6 +357,7 @@ int mhi_alloc_bhie_table(struct mhi_controller *mhi_cntrl,
    for (--i, --mhi_buf; i >= 0; i--, mhi_buf--)
    dma_free_coherent(mhi_cntrl->cntrl_dev, mhi_buf->len,
    mhi_buf->buf, mhi_buf->dma_addr);
    + kfree(img_info->mhi_buf);

    error_alloc_mhi_buf:
    kfree(img_info);
    --
    2.39.2

    \
     
     \ /
      Last update: 2024-05-27 14:51    [W:4.392 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site