Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 7 Feb 2024 13:31:52 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH 1/2] hwmon: chipcap2: fix uninitialized variable in cc2_get_reg_val() |
| |
On Wed, Feb 07, 2024 at 10:17:08PM +0100, Javier Carrasco wrote: > The reg_val variable in cc2_get_reg_val() might be used without a known > value if cc2_read_reg() fails. That leads to a useless data conversion > because the returned error means the read operation failed and the data is > not relevant. > > That makes its initial value irrelevant as well, so skip the data > conversion instead. If no error happens, a value is assigned to reg_val > and the data conversion is required. > > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/linux-hwmon/294e4634-89d4-415e-a723-b208d8770d7c@gmail.com/T/#t > Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Applied.
Thanks, Guenter
| ![\](/images/icornerr.gif) |