lkml.org 
[lkml]   [2024]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.7 33/44] nvmet-fc: release reference on target port
    Date
    From: Daniel Wagner <dwagner@suse.de>

    [ Upstream commit c691e6d7e13dab81ac8c7489c83b5dea972522a5 ]

    In case we return early out of __nvmet_fc_finish_ls_req() we still have
    to release the reference on the target port.

    Reviewed-by: Hannes Reinecke <hare@suse.de>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Daniel Wagner <dwagner@suse.de>
    Signed-off-by: Keith Busch <kbusch@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/nvme/target/fc.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c
    index bd59990b5250..8cd1ef293769 100644
    --- a/drivers/nvme/target/fc.c
    +++ b/drivers/nvme/target/fc.c
    @@ -360,7 +360,7 @@ __nvmet_fc_finish_ls_req(struct nvmet_fc_ls_req_op *lsop)

    if (!lsop->req_queued) {
    spin_unlock_irqrestore(&tgtport->lock, flags);
    - return;
    + goto out_puttgtport;
    }

    list_del(&lsop->lsreq_list);
    @@ -373,6 +373,7 @@ __nvmet_fc_finish_ls_req(struct nvmet_fc_ls_req_op *lsop)
    (lsreq->rqstlen + lsreq->rsplen),
    DMA_BIDIRECTIONAL);

    +out_puttgtport:
    nvmet_fc_tgtport_put(tgtport);
    }

    --
    2.43.0

    \
     
     \ /
      Last update: 2024-05-27 14:53    [W:4.817 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site