Messages in this thread | | | Date | Thu, 29 Feb 2024 11:12:49 +0800 | Subject | Re: [PATCH v2 1/2] x86/resctrl: Rename pseudo_lock_event.h to trace.h | From | Haifeng Xu <> |
| |
On 2024/2/24 04:00, Reinette Chatre wrote: > Hi Haifeng, > > On 2/21/2024 1:21 AM, Haifeng Xu wrote: >> Now only pseudo-lock part uses tracepoints to do event tracking, but >> other parts of resctrl may need new tracepoints. It is unnecessary to >> create separate header files and define CREATE_TRACE_POINTS in different >> c files which fragments the resctrl tracing. >> >> Therefore, the new tracepoints should be placed in the same header file, >> and the header file needs a more generic name. > > Please do stick with imperative mood [1]. For example, something like: > "Give the resctrl tracepoint header file a generic name to support > its use for tracepoints that are not specific to pseudo-locking." > > (Please feel free to improve.)
Thanks for you suggestion.
> > Reinette > > [1] https://urldefense.proofpoint.com/v2/url?u=https-3A__www.kernel.org_doc_html_latest_process_maintainer-2Dtip.html-23changelog&d=DwICaQ&c=R1GFtfTqKXCFH-lgEPXWwic6stQkW4U7uVq33mt-crw&r=3uoFsejk1jN2oga47MZfph01lLGODc93n4Zqe7b0NRk&m=JoQ5pMB6FFBeGHFDWQYyFgKF2Y5VYhBeykX4853MHrTi-O0Jk3H_K9bh3NaxwLRx&s=482No-jEnFTObHttNwp2LTS-Dc3cP5jQOhL2cEj77MM&e= >
| |