Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 29 Feb 2024 16:15:35 +0100 | Subject | Re: [PATCH v7 07/11] dt-bindings: usb: ci-hdrc-usb2-imx: remove fsl,anatop property | From | Krzysztof Kozlowski <> |
| |
On 28/02/2024 12:30, Xu Yang wrote: > Property "fsl,anatop" is needed by usb phy rather usb controller. > This will remove it from ci-hdrc-usb2-imx schema. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > Changes in v7: > - new patch > --- > Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > index a2932af2c09b..0a6ebb427130 100644 > --- a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > @@ -74,10 +74,6 @@ properties: > - description: phandle to usbmisc node > - description: index of usb controller > > - fsl,anatop: > - description: phandle for the anatop node. > - $ref: /schemas/types.yaml#/definitions/phandle
Then why did you copy it from original schema? Just remove it before all this work.
Again: Do not add lines in one patch which immediately later are being removed. Such patchset has no effect and is only confusing. This suggests your order is incorrect.
Best regards, Krzysztof
| ![\](/images/icornerr.gif) |