Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 29 Feb 2024 14:49:16 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2 12/14] regulator: tps6594-regulator: Add TI TPS65224 PMIC regulators |
| |
On Thu, Feb 29, 2024 at 03:42:50PM +0100, Esteban Blanc wrote: > On Fri Feb 23, 2024 at 10:36 AM CET, Bhargav Raviprakash wrote:
> > + /* Number of interrupts supported by each voltage source */ > > + interrupt_cnt = (tps->chip_id == TPS6594) ? > > + ARRAY_SIZE(tps6594_buck1_irq_types) : > > + ARRAY_SIZE(tps65224_buck1_irq_types);
> The comment is not adding anything, the name is clear and ARRAY_SIZE is > quite explicit.
Also please don't abuse the ternery operator like this, write normal conditionals or for a case like this where we may get more options in future use switch statements. [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |