Messages in this thread | | | Date | Thu, 29 Feb 2024 12:41:22 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/2] devres: Switch to use dev_err_probe() for unification |
| |
On Thu, Feb 29, 2024 at 12:39:55PM +0200, Andy Shevchenko wrote: > On Thu, Feb 29, 2024 at 09:52:34AM +0100, Philipp Stanner wrote: > > On Tue, 2024-02-27 at 19:58 +0200, Andy Shevchenko wrote:
..
> > That way it would be obvious that the error code is never changed and > > it will always return -EINVAL. Otherwise you have to look up the > > function definition of dev_err_probe().
And to this, it's a common pattern in some cases, esp. when you have a chain of the similar calls and you want to simplify the code (see CCI accessors in Video4Linux2 as an example). So, I also don't think it's something unusual.
-- With Best Regards, Andy Shevchenko
| |