| From | Linus Walleij <> | Date | Thu, 29 Feb 2024 10:26:36 +0100 | Subject | Re: [PATCH v2 10/30] pinctrl: nomadik: minimise indentation in probe |
| |
On Wed, Feb 28, 2024 at 12:28 PM Théo Lebrun <theo.lebrun@bootlin.com> wrote:
> nmk_pinctrl_probe() iterates over each GPIO block. Use an early > conditional continue to skip to the next iteration rather than indent > all the loop code block. > > Do not change code logic. The block is changed from: > > for (i = 0; i < NMK_MAX_BANKS; i++) { > x = of_parse_phandle(...); > if (x) { > ... do work ... > } > } > > To: > > for (i = 0; i < NMK_MAX_BANKS; i++) { > x = of_parse_phandle(...); > if (!x) > continue; > > ... do work ... > } > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
Patch applied!
Yours, Linus Walleij
|